Skip to content

Conversation

@brfrn169
Copy link
Collaborator

Description

Since we switched the snapshot repository used for uploading SNAPSHOT versions in ScalarDL (scalar-labs/scalardl#194) and ScalarDB (scalar-labs/scalardb#2849), we should also update the repository reference accordingly. This PR addresses that.

Related issues and/or PRs

Changes made

  • Updated the snapshot repository references.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Copilot AI review requested due to automatic review settings September 24, 2025 07:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Maven snapshot repository URLs from the legacy Sonatype OSS repository to the new Central Sonatype repository to align with changes made in related ScalarDL and ScalarDB projects.

  • Updated snapshot repository URLs in build configuration files
  • Ensures consistency with repository changes made in dependent projects

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scalardl-test/build.gradle Updated Maven snapshot repository URL from legacy OSS Sonatype to Central Sonatype
scalardb-test/build.gradle Updated Maven snapshot repository URL from legacy OSS Sonatype to Central Sonatype

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gemini-code-assist
Copy link

Summary of Changes

Hello @brfrn169, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Maven snapshot repository URL within the build.gradle files for the scalardb-test and scalardl-test modules. The primary purpose is to standardize the snapshot repository reference across the ecosystem, following recent changes in ScalarDL and ScalarDB projects. This ensures that all related projects correctly fetch snapshot dependencies from the designated Sonatype Maven snapshot repository.

Highlights

  • Maven Snapshot Repository Update: The Maven snapshot repository URL has been updated in both scalardb-test/build.gradle and scalardl-test/build.gradle.
  • Consistency Across Projects: This change aligns the snapshot repository reference with the new standard adopted by related projects, ScalarDL and ScalarDB, ensuring consistent dependency resolution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@brfrn169 brfrn169 self-assigned this Sep 24, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Maven snapshot repository URL in scalardb-test/build.gradle and scalardl-test/build.gradle. The change itself is correct and aligns with the migration to the new Sonatype repository. I've added one suggestion to address the duplication of the repository URL across build files, which will improve the maintainability of the project.

Copy link
Contributor

@inv-jishnu inv-jishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you.

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit dc4a475 into master Sep 26, 2025
@feeblefakie feeblefakie deleted the update-maven-snapshot-repository branch September 26, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants